Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package sonar-channel that is removed from SonarQube plugin API 7.4 #227

Merged
merged 6 commits into from
Nov 24, 2018
Merged

Package sonar-channel that is removed from SonarQube plugin API 7.4 #227

merged 6 commits into from
Nov 24, 2018

Conversation

KengoTODA
Copy link
Member

As described in #225, sonar-channel and commons-io has been removed from SonarQube plugin API 7.4. This is why the build with SonarQube plugin API 7.4 is failing, and sonar-findbugs 3.9 lacks compatibility with SonarQube 7.4.

In this PR, I reproduce reported issue #226 by smoke test, and fix it by packaging sonar-channel and commons-io into sonar-findbugs. We need to use maven-shade-plugin because sonar-packaging-maven-plugin does not package these two libraries. Here is message:

[WARNING] commons-io:commons-io:jar:2.6:compile is provided by SonarQube plugin API and will not be packaged in your plugin
[WARNING] org.codehaus.sonar:sonar-channel:jar:4.2:compile is provided by SonarQube plugin API and will not be packaged in your plugin

So to support both SonarQube 6.7 and 7.4, we need to shade these libraries. To avoid classloader related issue, I also changed their package path.

This PR closes #225 and #226.

@KengoTODA
prepare for next patch release
8a38539
@KengoTODA
reproduce reported issue by smoke test
754889b
@KengoTODA
package sonar-channel that is removed from SQ 7.4
86288b1 
By default sonar-channel is not packaged into sonarqube plugin, because
sonarqube plugin API v6.7 provides them to plugin.
However, SonarQube 7.4 does not provide them to plugins, so
we plugin provider need to package them by own.

https://jira.sonarsource.com/browse/SONAR-10331?focusedCommentId=190952&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-190952
@KengoTODA KengoTODA added the bug label Nov 14, 2018
@KengoTODA KengoTODA self-assigned this Nov 14, 2018
This was referenced Nov 14, 2018
Closed
Closed
@KengoTODA
Copy link
Member Author

I'm investigating why docker-compose build failed in 25de4c9

@KengoTODA
Copy link
Member Author

@h3xstream @VinodAnandan Our build in this branch is now stable, please review and merge this.
Then we can release v3.9.1 that supports SonarQube 7.4.

@KengoTODA KengoTODA mentioned this pull request Nov 21, 2018
Closed
@seenusankara
Copy link

@h3xstream @VinodAnandan , Can someone please merge this changes. We are in process of Migration of SonarQube from 6.7 to 7.4.

@VinodAnandan
Copy link
Collaborator

LGTM

@VinodAnandan VinodAnandan merged commit 53c8d13 into master Nov 24, 2018
@VinodAnandan VinodAnandan mentioned this pull request Nov 24, 2018
Closed
@VinodAnandan
Copy link
Collaborator

Smoke Test failed.
https://travis-ci.org/spotbugs/sonar-findbugs/builds/458992395

@KengoTODA
Copy link
Member Author

I've checked its build log and it seems that Travis' filesystem had some trouble to create directory.

[WARNING] Failed to create parent directories for tracking file /home/travis/.m2/repository/joda-time/joda-time/2.2/joda-time-2.2.pom.lastUpdated
...
[ERROR] Unresolveable build extension: Plugin org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8 or one of its dependencies could not be resolved: Failed to collect dependencies at org.sonatype.plugins:nexus-staging-maven-plugin:jar:1.6.8 -> org.sonatype.nexus:nexus-client-core:jar:2.14.3-02 -> joda-time:joda-time:jar:2.2 @

I'll rerun failed builds, to ensure that master branch itself has no problem. After that, I will push new tag to GitHub.

@KengoTODA KengoTODA deleted the fix-issue-226 branch November 25, 2018 03:10
@KengoTODA
Copy link
Member Author

KengoTODA commented Nov 25, 2018 •
edited
Loading

3.9.1 is now published at Maven central.
http://central.maven.org/maven2/com/github/spotbugs/sonar-findbugs-plugin/3.9.1/

@ddcruver
Copy link

When will this be available in SonarQube Marketplace?

@KengoTODA
Copy link
Member Author

@ddcruver I strongly recommend you to install from Maven central. Release to Marketplace always takes long time.

At least, we need to wait three days to get feedback like this, then again wait several days (or weeks) to deploy artifact to marketplace like this.

@KengoTODA
Copy link
Member Author

@VinodAnandan 3.9.0 has been released to marketplace, so I made a topic regarding RFF for 3.9.1.

@VinodAnandan
Copy link
Collaborator

Thank you @KengoTODA

@KengoTODA
Copy link
Member Author

I also posted the request to deploy 3.9.1 at sonarsource forum.

@KengoTODA
Copy link
Member Author

Finally 3.9.1 has been published to marketplace.

@KengoTODA KengoTODA mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KengoTODA KengoTODA

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace dependency on org.sonar.channel to org.sonar.sslr.channel
4 participants
@KengoTODA @seenusankara @VinodAnandan @ddcruver